[PATCH] D22885: TargetInstrInfo: add virtual function GetInstSizeInBytes

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 13:50:59 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D22885#498210, @SjoerdMeijer wrote:

> Thanks for reviewing.
>  I have added llvm_unreachable as the default implementation instead of 4.
>  Can we keep the function name that starts with a capital letter because that's the function that 6 targets already implement?


You have to touch all of them anyway to add the overrides, so might as well fix the name while you're at it


https://reviews.llvm.org/D22885





More information about the llvm-commits mailing list