[PATCH] D22701: [test-suite] Bitcode simd tests: align memory to 128.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 12:54:18 PDT 2016


echristo added a comment.

One inline comment :)


================
Comment at: Bitcode/simd_ops/simd_ops.cpp:6
@@ +5,3 @@
+#include <malloc.h>
+#define posix_memalign(p, a, s) (((*(p)) = _aligned_malloc((s), (a))), *(p) ?0 :errno)
+#endif
----------------
Comment what's going on here and why we're allocating memory if you wouldn't mind? It might be nicer for this to be a function rather than a macro? Just call it alloc_aligned or something and have the functionality for all 3 platforms in there?


https://reviews.llvm.org/D22701





More information about the llvm-commits mailing list