[PATCH] D22846: [RFC] AMDGPU: add execfix flag to SI_ELSE

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 11:31:51 PDT 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, except for the operand type. Also, can you add a test which shows a change from moving the modifiesRegister so that it doesn't also count the else (since I think this should fix it?)


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:1954
@@ -1953,4 +1953,3 @@
 def SI_ELSE : PseudoInstSI <
-  (outs SReg_64:$dst), (ins SReg_64:$src, brtarget:$target),
-  [(set i64:$dst, (int_amdgcn_else i64:$src, bb:$target))]> {
+  (outs SReg_64:$dst), (ins SReg_64:$src, brtarget:$target, SSrc_32:$execfix)> {
   let Constraints = "$src = $dst";
----------------
This should be i1imm instead of SSrc since it's just an immediate


https://reviews.llvm.org/D22846





More information about the llvm-commits mailing list