[PATCH] D22744: CodeExtractor : Add ability to preserve profile data.
    River Riddle via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jul 27 11:14:45 PDT 2016
    
    
  
rriddle added inline comments.
================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:693
@@ +692,3 @@
+  for (auto &Weight : ExitWeights) {
+    if (Weight.second.getFrequency() == 0) {
+      HasValidWeights = false;
----------------
davidxl wrote:
> This check does not look correct. It is possible for the frequency to be zero
Yeah, that was my understanding. Thanks for the sanity check! I need to add the weights without using the current methods given that they do not allow for weights of 0.
https://reviews.llvm.org/D22744
    
    
More information about the llvm-commits
mailing list