[PATCH] D22683: [ELF] Symbol assignment within input section list

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 09:42:22 PDT 2016


evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:162
@@ +161,3 @@
+
+      AddPendingSyms();
+    }
----------------
AddPendingSyms() adds symbols to current output section, clearing the pending state.
This happens in two cases:
a) Before we add non-virtual input section to output section, but after output section was created in call to Factory.create()
b) After we processed all input section commands. The list of pending symbols may not be empty, if symbols are declared in the end of section description, for example 'end_foo' symbol:

```
SECTIONS { .foo : { *(.foo) : end_foo = .; } }
```

================
Comment at: ELF/LinkerScript.h:63
@@ -61,1 +62,3 @@
+  // beginning of its output section.
+  uint64_t Value = 0;
 };
----------------
This is no longer needed, I'll remove in next iteration


https://reviews.llvm.org/D22683





More information about the llvm-commits mailing list