[PATCH] D22775: [ARM] Set a non-conflicting comment character for assembly in MSVC mode

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 04:09:50 PDT 2016


mstorsjo updated this revision to Diff 65701.
mstorsjo added a comment.

Simplified the test, as suggested


https://reviews.llvm.org/D22775

Files:
  lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
  test/MC/ARM/Windows/literals-comments.s

Index: test/MC/ARM/Windows/literals-comments.s
===================================================================
--- /dev/null
+++ test/MC/ARM/Windows/literals-comments.s
@@ -0,0 +1,13 @@
+; RUN: llvm-mc -triple armv7-windows-msvc -filetype obj -o - %s
+
+	.syntax unified
+	.thumb
+
+	.text
+
+	.global function
+	.thumb_func
+function:
+	; this is a comment
+	mov r0, #42 ; this # was not
+	bx lr
Index: lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
===================================================================
--- lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
+++ lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
@@ -90,6 +90,7 @@
 
   PrivateGlobalPrefix = "$M";
   PrivateLabelPrefix = "$M";
+  CommentString = ";";
 }
 
 void ARMCOFFMCAsmInfoGNU::anchor() { }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22775.65701.patch
Type: text/x-patch
Size: 769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160727/9f607d98/attachment.bin>


More information about the llvm-commits mailing list