[PATCH] D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function.

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.
silvas added a comment.

The convention of putting the date in the test file name is no longer in fashion, so you can call the test file just InheritAttributes.ll


================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/Utils/CodeExtractor.cpp:393
@@ +392,3 @@
+      //  in the original function.
+      AI->addAttr(Attribute::NoAlias);
+      AI->addAttr(Attribute::NonNull);
----------------
Can you split this into a separate patch with its own test case?

================
Comment at: /Users/rriddle/Desktop/llvm/llvm/test/Transforms/CodeExtractor/2016-07-20-InheritAttributes.ll:1
@@ +1,2 @@
+; RUN: opt < %s -partial-inliner | llc -filetype=null
+; This testcase tests inheriting target attributes
----------------
You should also add a RUN line that pipes to FileCheck and actually checks for the expected result (e.g. specific attributes on the extracted function).


https://reviews.llvm.org/D22713