[PATCH] D22758: [compiler-rt] Fix warnings in interception code

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 17:45:04 PDT 2016


etienneb added a comment.

In https://reviews.llvm.org/D22758#496945, @rnk wrote:

> In https://reviews.llvm.org/D22758#495682, @kcc wrote:
>
> > please remember to *NOT* use #ifdef if if() is an alternative. 
> >  If you can only use #ifdef, think again.
>
>
> We either have to use ifdef in this case or some other contortion to avoid a warning about the address of a function never being null.


On apple, that code is generating a warning:

  if (REAL(memchr)) {

The condition is always true.


https://reviews.llvm.org/D22758





More information about the llvm-commits mailing list