[PATCH] D22839: Revert EH-specific branch folding changes to avoid compilation slow down

Andy Kaylor via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 17:36:25 PDT 2016


andrew.w.kaylor created this revision.
andrew.w.kaylor added reviewers: majnemer, JosephTremoulet.
andrew.w.kaylor added subscribers: MatzeB, llvm-commits.
andrew.w.kaylor set the repository for this revision to rL LLVM.

This patch reverts a previous change (D14996) which was blowing up compilation times under certain circumstances.  I don't think the conditions which motivated that change can occur since the introduction of catchswitch statements.

Reverting this change led to a couple of tests failing because the order of exception handlers is different than the tests expect, but I do not believe the difference is significant so I just updated the tests to reflect the new order.  I'm posting this review primarily to get a second opinion on that judgment.

Repository:
  rL LLVM

https://reviews.llvm.org/D22839

Files:
  lib/CodeGen/BranchFolding.cpp
  test/CodeGen/WinEH/wineh-noret-cleanup.ll
  test/CodeGen/X86/wineh-coreclr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22839.65638.patch
Type: text/x-patch
Size: 6979 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160727/2efa968d/attachment.bin>


More information about the llvm-commits mailing list