[PATCH] D22585: [MC][X86] Fix Intel Operand assembly parsing for .set ids

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 16:32:59 PDT 2016


rnk added inline comments.

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1439
@@ +1438,3 @@
+    if (SM.getSym()) {
+      Error(Start, "cannot use more than one symbol in memory operand");
+      return nullptr;
----------------
Can you add a few negative tests exercising these errors? Look at how intel-syntax-ambiguous.s tests erroneous input.


https://reviews.llvm.org/D22585





More information about the llvm-commits mailing list