[PATCH] D22827: [test/gold] Add gold test subdirectory tests needing v1.12 (or higher)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 13:37:05 PDT 2016


tejohnson added inline comments.

================
Comment at: test/tools/gold/X86/v1.12/lit.local.cfg:18
@@ +17,3 @@
+    return False
+  version = float(match.group(1))
+  if version < 1.12:
----------------
davidxl wrote:
> probably just look at the minor version and use integer comparison? version 1.2 should be older version right?
Ah yes, good catch. I should probably compare both separately, in case the major version ever increases. Will fix.


https://reviews.llvm.org/D22827





More information about the llvm-commits mailing list