[PATCH] D22686: [WASM] SIMD128 support.

[Dan Gohman via llvm-commits]

sunfish added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblySubtarget.cpp:69
@@ +68,3 @@
+    if (HasSIMD128)
+      return true;
+    return false;
----------------
jpp wrote:
> sunfish wrote:
> > It's not necessary to check HasSIMD128 here, because we shouldn't have created an ARGUMENT_v16i8 etc. if we don't have HasSIMD128 in the first place :-). And without that check, this function doesn't need to be a member of WebAssemblySubtarget.
> > 
> > The same applies to other hasSIMD128() checks in the patch as well.
> I was debating whether I should add all these hasSIMD128() checks everywhere or not, and then I decided to be pedantic. Should I remove them all?
I favor removing them. We have to think about the subtarget restrictions when creating new instructions, but it's nice for code that's just reading instructions to just handle all of wasm.


Repository:
  rL LLVM

https://reviews.llvm.org/D22686