[PATCH] D22759: [ELF] Linkerscript: symbol assignments with indentifiers on the right side of expression.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/LinkerScript.cpp:746
@@ -745,1 +745,3 @@
 
+uint64_t static getSymbolValue(StringRef S) {
+  switch (Config->EKind) {
----------------
`uint64_t static` -> `static uint64_t`.

================
Comment at: ELF/LinkerScript.cpp:764-765
@@ +763,4 @@
+    break;
+  default:
+    llvm_unreachable("unknown ELF kind");
+  }
----------------
We don't need this guard.

================
Comment at: ELF/LinkerScript.cpp:851
@@ -825,3 +850,3 @@
 
   // Parse a number literal
   uint64_t V = 0;
----------------
Parse a symbol name or a number literal.


https://reviews.llvm.org/D22759