[PATCH] D21379: [X86] Heuristic to selectively build Newton-Raphson SQRT estimation

[Nikolai Bozhenov via llvm-commits]

n.bozhenov updated this revision to Diff 65527.
n.bozhenov added a comment.

> In general, however, the rationale needs to be much better documented in the code. I don't see any comments in the patch itself about the latency/throughput tradeoff.


Hal, you are right. The patch lacked comments explaining the tradeoff.
The new version of the patch adds the missed comment to X86.td file.


https://reviews.llvm.org/D21379

Files:
  include/llvm/Target/TargetLowering.h
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.h
  lib/Target/X86/X86.td
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  lib/Target/X86/X86Subtarget.cpp
  lib/Target/X86/X86Subtarget.h
  test/CodeGen/X86/sqrt-fastmath-tune.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21379.65527.patch
Type: text/x-patch
Size: 11660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160726/45abc1cc/attachment.bin>