[compiler-rt] r276541 - Revert r276539 "Silence -Wpointer-bool-conversion warning after r276324"

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 19:49:36 PDT 2016


Sorry about that Kostya, was helpless trying to fix a internal bot!

On Mon, Jul 25, 2016 at 7:26 PM, Kostya Serebryany <kcc at google.com> wrote:
> also, AFAICT, the change was not code reviewed. (please correct me if I am
> wrong)
> and it it were, I wouldn't like it.
>
> On Sat, Jul 23, 2016 at 6:27 PM, Bruno Cardoso Lopes via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: bruno
>> Date: Sat Jul 23 20:27:07 2016
>> New Revision: 276541
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=276541&view=rev
>> Log:
>> Revert r276539 "Silence -Wpointer-bool-conversion warning after r276324"
>>
>> Some bots are not happy with the change.
>> This reverts commit d307ca28083065851ad969444f3c063562f2d4bd.
>>
>> Modified:
>>
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc
>>
>> Modified:
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=276541&r1=276540&r2=276541&view=diff
>>
>> ==============================================================================
>> ---
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc
>> (original)
>> +++
>> compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc Sat
>> Jul 23 20:27:07 2016
>> @@ -664,7 +664,7 @@ INTERCEPTOR(void*, memchr, const void *s
>>    void *ctx;
>>    COMMON_INTERCEPTOR_ENTER(ctx, memchr, s, c, n);
>>    void *res;
>> -  if (REAL(&memchr)) {
>> +  if (REAL(memchr)) {
>>      res = REAL(memchr)(s, c, n);
>>    } else {
>>      res = internal_memchr(s, c, n);
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc


More information about the llvm-commits mailing list