[PATCH] D22160: PowerPC: Avoid implicit iterator conversions, NFC

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 17:50:51 PDT 2016


> On 2016-Jul-25, at 18:34, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> 
> mehdi_amini added a subscriber: mehdi_amini.
> mehdi_amini accepted this revision.
> mehdi_amini added a reviewer: mehdi_amini.
> mehdi_amini added a comment.
> This revision is now accepted and ready to land.
> 
> This is very mechanical (and passed bootstrap testing already apparently). LGTM.

Thanks!  I'll try to commit tomorrow.

> ================
> Comment at: lib/Target/PowerPC/PPCVSXCopy.cpp:120
> @@ -123,1 +119,3 @@
> +              .addImm(IsVRReg(SrcMO.getReg(), MRI) ? PPC::sub_128
> +                                                   : PPC::sub_64);
> 
> ----------------
> You're changing nothing but the formatting on this line, aren't you?

You quoted that without context so I can't see right now, but I suspect something else in the statement changed and this is a result of clang-format.  I'll double-check before committing.


More information about the llvm-commits mailing list