[PATCH] D22776: [ARM] Set the thumb flag for all text segments on COFF (partial revert of recent commit)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 13:46:46 PDT 2016


rengolin added a comment.

> When assembling files via clang, even if the target triple set on the command line is e.g. thumb-win32, the driver sets the triple to armv7--windows-msvc18.0.0 (or similar; see tools/clang/lib/Driver/ToolChain.cpp) since assembly files should start in ARM mode by default.


This makes no sense. If this is an assembly file, it should have some Thumb markers (.code 16, .thumb_func)  to be classified as Thumb. You can't just assume it's Thumb because "COFF is probably Windows".


https://reviews.llvm.org/D22776





More information about the llvm-commits mailing list