[PATCH] D22373: [GlobalISel] Introduce a simple instruction selector.

[Quentin Colombet via llvm-commits]

qcolombet added inline comments.

================
Comment at: lib/CodeGen/MachineRegisterInfo.cpp:60
@@ -59,3 +59,3 @@
     return NewRC;
   if (NewRC->getNumRegs() < MinNumRegs)
     return nullptr;
----------------
Actually what I had in mind was to get the size from the type with, like you said, querying the MI for the def size (via getUniqueDef). However, we would still need to access this information from the vreg.
As having the type on the vreg, no, that does not work. Vregs can change type based on their uses (like and s64, add <2 x s32>).

But yeah, long term, this code shouldn't be needed. Add a comment about that?


https://reviews.llvm.org/D22373