[PATCH] D22751: AMDGPU Device Libs pass.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 10:55:13 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D22751#494978, @nhaustov wrote:

> In https://reviews.llvm.org/D22751#494940, @arsenm wrote:
>
> > Should this really be in the backend? I also thought we were going to use a global constant variable instead of a function call
>
>
> Yes, it needs to be. Global variable approach doesn't support functions in different modes. 
>  Any specific concerns with the patch?


The idea was that would be controlled by multiple globals with private visibility in different modules linked together.
Why does it need to be in the backend? This seems more like a pass that belongs with the runtime/compiler library when linking the AMD specific library


https://reviews.llvm.org/D22751





More information about the llvm-commits mailing list