[PATCH] D22491: Added ThinLTO inlining statistics

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: test/Transforms/Inline/inline_stats.ll:17
@@ +16,3 @@
+; CHECK: Inlined not imported functions: 1 [33.33%]
+; CHECK: non-imported functions inlined into importing module: 1 [100%]
+
----------------
tejohnson wrote:
> It isn't clear what the percentages represent (e.g. some are percent of total # functions and some are percent of inlined functions). Probably need to add a tag - e.g.:
> 
> ; CHECK: inlined functions: 5 [50% of all functions]
> ; CHECK: imported functions inlined: 4 [57.14% of imported functions]
> ; CHECK: imported functions inlined into importing module: 3 [75% of inlined imported functions]
> ; CHECK: Inlined not imported functions: 1 [33.33% of non-imported functions]
> ; CHECK: non-imported functions inlined into importing module: 1 [100% of non-imported inlined functions]
> 
> However, after typing that out, I think for the stat relating to how many are inlined into the importing module, it would be much more useful to have the percentage in terms of the total number of that type of function. E.g. instead of expressing the "imported functions inlined into importing module" as a percentage of "imported functions inlined", it would be more useful to have it be a percentage of "imported functions". Ditto for non-imported functions inlined into importing module.
Could you add one more stat - the # of imported functions not inlined into importing module (along with percentage of all imported functions)? I know it is computable from the other stats, but it would be useful to be able to get this directly.


https://reviews.llvm.org/D22491