[PATCH] D22685: Disable shrinking of SNaN constants on SystemZ

[Ulrich Weigand via llvm-commits]

uweigand added a comment.

I agree this seems broken; we shouldn't shrink SNaN constants.  However, I still have two comments:

1.) Does this actually have to be platform-specific?  I mean, is there any platform where a SNaN constant *can* be stored in converted form?  I would have expected that the type-conversion operation needed to load a "shrunk" SNaN constant would be required to actually trigger the "signaling" part of the SNaN (i.e. raise an invalid operation exception) on all platforms ...

2.) To detect an SNaN, you're testing for bitwise-equality against one specific SNaN value.  However, in general there can be many different SNaN values.  I think you should just test for APF.isSignaling().


https://reviews.llvm.org/D22685