[PATCH] D19178: Broaden FoldItoFPtoI to try and establish whether the integer value fits into the float type

[Carlos Liam via llvm-commits]

aarzee added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1507
@@ +1506,3 @@
+    Safe = BitRange <= SignificandWidth && MostSignificantPossiblySetBit <
+      APFloat::semanticsMaxExponent(OpITy->getFltSemantics());
+  }
----------------
eli.friedman wrote:
> Thinking about it a bit more, we don't actually care if the exponent overflows; the end result would be undef, so it doesn't matter.
Is this explicitly defined somewhere?


https://reviews.llvm.org/D19178