[PATCH] D21460: [JumpThreading] Fix handling of aliasing metadata.

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:965
@@ +964,3 @@
+          LLVMContext::MD_dereferenceable_or_null};
+      combineMetadata(NLI, LI, KnownIDs);
+    };
----------------
eli.friedman wrote:
> hfinkel wrote:
> > hiraditya wrote:
> > > The declaration of KnownIDs seem to be repeated at other places e.g., line 827. Is there a way to merge them, possibly put them all in a separate function.
> > I agree; we'll now have this list of 'metadata which is safe to merge on memory-access CSE'. Let's put this list somewhere common.
> Okay; should I add a new utility method called "combineMetadataForMemoryCSE", or do you have some other suggestion?
SGTM; and with that, this LGTM.


https://reviews.llvm.org/D21460