[PATCH] D22726: [DAGCombine] Match shift amount by value rather than relying on common sub-expressions.

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 23 15:32:48 PDT 2016


eli.friedman added a subscriber: eli.friedman.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4832
@@ +4831,3 @@
+      isa<ConstantSDNode>(N0.getOperand(1)) &&
+      cast<ConstantSDNode>(N0.getOperand(1))->getZExtValue() ==
+          N1C->getZExtValue()) {
----------------
You can't use getZExtValue on an arbitrary constant; it will crash if the constant is too large.


Repository:
  rL LLVM

https://reviews.llvm.org/D22726





More information about the llvm-commits mailing list