[PATCH] D22044: [X86] Support of no_caller_saved_registers attribute (LLVM part)

[Quentin Colombet via llvm-commits]

qcolombet added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3374
@@ -3365,1 +3373,3 @@
+        //        X86_INTR calling convention. Is there a better way to do this?
+        MF, HasNCSR ? CallingConv::X86_INTR: CallConv);
   assert(Mask && "Missing call preserved mask for calling convention");
----------------
The right way to do this, IMO, is to add the calling convention in LLVM like all other ones and have clang/the front-end selects the right calling convention when it sees the attribute.
In other words, I don’t think we want to push attribute checking in here.


https://reviews.llvm.org/D22044