[PATCH] D22491: Added ThinLTO inlining statistics

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 12:58:30 PDT 2016


Prazek added inline comments.

================
Comment at: lib/Transforms/Utils/ThinLTOInlinerStats.cpp:92
@@ +91,3 @@
+};
+
+ThinLTOInlinerStatistics::ThinLTOInlinerStatistics() { NonImportedCallers.reserve(200); }
----------------
mehdi_amini wrote:
> We don't add mutexes without motivation. You need to explain why *this* one makes sense (I.e. how it could get use in a multi-threaded environment in the future).
ok so we discussed it offline, and the main problem here is that multiple ThinLTO threads would use it. The solution is to create new InlinerStatistic object in Inliner and remove mutexes.


https://reviews.llvm.org/D22491





More information about the llvm-commits mailing list