[llvm] r276453 - [ThinLTO/gold] Remove thin archive part of new test due to bot failures

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 11:32:31 PDT 2016


Author: tejohnson
Date: Fri Jul 22 13:32:30 2016
New Revision: 276453

URL: http://llvm.org/viewvc/llvm-project?rev=276453&view=rev
Log:
[ThinLTO/gold] Remove thin archive part of new test due to bot failures

I am getting a bot failure from the thin archive part of this test:

From
http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40468/steps/test_llvm/logs/LLVM%20%3A%3A%20tools__gold__X86__thinlto_emit_linked_objects.ll:

Command Output (stderr):
--
/home/bb/cmake-llvm-x86_64-linux/build/./bin/llvm-ar: creating
/home/bb/cmake-llvm-x86_64-linux/build/test/tools/gold/X86/Output/thinlto_emit_linked_objects.ll.tmp2.a
/usr/bin/ld.gold: internal error in add_writer, at
../../gold/token.h:124

--

This appears to be an issue with an older version of gold. The test case
passes for me locally when I use the gold v1.12 I was testing with, but
when I tried the gold installed on my system which is v1.11 I get the
same error.

Remove the thin archive version of the test, since there isn't a way to
predicate it on gold version.

Modified:
    llvm/trunk/test/tools/gold/X86/thinlto_emit_linked_objects.ll

Modified: llvm/trunk/test/tools/gold/X86/thinlto_emit_linked_objects.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/thinlto_emit_linked_objects.ll?rev=276453&r1=276452&r2=276453&view=diff
==============================================================================
--- llvm/trunk/test/tools/gold/X86/thinlto_emit_linked_objects.ll (original)
+++ llvm/trunk/test/tools/gold/X86/thinlto_emit_linked_objects.ll Fri Jul 22 13:32:30 2016
@@ -17,19 +17,7 @@
 ; RUN:    %t.o \
 ; RUN:    --start-lib %t2.o --end-lib
 
-; Do the same check for a thin archive (note that non-thin archives don't play
-; well with thinlto-index-only because we need to have an object file to
-; import from in the distributed ThinLTO backends).
-; RUN: llvm-ar Tr %t2.a %t2.o
-; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
-; RUN:    --plugin-opt=thinlto \
-; RUN:    --plugin-opt=thinlto-index-only=%t4 \
-; RUN:    -o %t5 \
-; RUN:    %t.o \
-; RUN:    %t2.a
-
 ; RUN: cat %t3 | FileCheck %s
-; RUN: cat %t4 | FileCheck %s
 ; CHECK: thinlto_emit_linked_objects.ll.tmp.o
 ; CHECK: thinlto_emit_linked_objects.ll.tmp2.o
 




More information about the llvm-commits mailing list