[PATCH] D22660: [ELF/LinkerScript] Support ONLY_IF_{RO, RW} directive

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 20:38:47 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:815
@@ +814,3 @@
+  // Parse constraints.
+  StringRef Tok = peek();
+  if (skip("ONLY_IF_RO"))
----------------
You want to remove this line.


https://reviews.llvm.org/D22660





More information about the llvm-commits mailing list