[PATCH] D22625: [ELF] Support PROVIDE and PROVIDE_HIDDEN within SECTIONS {} block

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:877
@@ +876,3 @@
+    StringRef Tok = peek();
+    Braces += (Tok == "(");
+    Braces -= (Tok == ")");
----------------
This look a bit tricky. Straightforward code would be

  if (Tok == "(")
    ++Braces;
  else if (Tok == ")")
    --Braces;


https://reviews.llvm.org/D22625