[llvm] r276347 - [X86] Do not use AND8ri8 in AVX512 pattern

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 15:24:08 PDT 2016


Author: mkuper
Date: Thu Jul 21 17:24:08 2016
New Revision: 276347

URL: http://llvm.org/viewvc/llvm-project?rev=276347&view=rev
Log:
[X86] Do not use AND8ri8 in AVX512 pattern

This variant is (as documented in the TD) for disassembler use only, and should
not be used in patterns - it is longer, and is broken on 64-bit.

Added:
    llvm/trunk/test/CodeGen/X86/no-and8ri8.ll
Modified:
    llvm/trunk/lib/Target/X86/X86InstrAVX512.td

Modified: llvm/trunk/lib/Target/X86/X86InstrAVX512.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrAVX512.td?rev=276347&r1=276346&r2=276347&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrAVX512.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrAVX512.td Thu Jul 21 17:24:08 2016
@@ -2142,7 +2142,7 @@ let Predicates = [HasAVX512] in {
             (COPY_TO_REGCLASS (i16 (EXTRACT_SUBREG $src, sub_16bit)), VK1)>;
 
   def : Pat<(i1 (trunc (i8 GR8:$src))),
-            (COPY_TO_REGCLASS (i16 (SUBREG_TO_REG (i64 0), (AND8ri8 $src, (i8 1)),
+            (COPY_TO_REGCLASS (i16 (SUBREG_TO_REG (i64 0), (AND8ri $src, (i8 1)),
                                     sub_8bit)), VK1)>;
 
   def : Pat<(i1 (trunc (i8 (assertzext_i1 GR8:$src)))),

Added: llvm/trunk/test/CodeGen/X86/no-and8ri8.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/no-and8ri8.ll?rev=276347&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/no-and8ri8.ll (added)
+++ llvm/trunk/test/CodeGen/X86/no-and8ri8.ll Thu Jul 21 17:24:08 2016
@@ -0,0 +1,18 @@
+; RUN: llc -mtriple=x86_64-pc-linux -mattr=+avx512f --show-mc-encoding < %s | FileCheck %s
+
+declare i1 @bar() 
+
+; CHECK-LABEL: @foo
+; CHECK-NOT: andb {{.*}} # encoding: [0x82,
+define i1 @foo(i1 %i) nounwind {
+entry:
+  br i1 %i, label %if, label %else
+
+if:
+  %r = call i1 @bar()
+  br label %else
+
+else:
+  %ret = phi i1 [%r, %if], [true, %entry]
+  ret i1 %ret
+}




More information about the llvm-commits mailing list