[PATCH] D22644: [GVNHoist] Don't clone allocas (PR28606)

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 14:06:45 PDT 2016


sebpop requested changes to this revision.
sebpop added a comment.

> To be honest, I'm not entirely sure why we must clone the value because we've already checked to see that it is available at the hoist point


Right, I think we do not need to clone the value.
I think we still need to clone a GEP as they are not hoisted without their ld/st.
As we are after the check for allOperandsAvailable on the stored value,
we should remove all the code cloning the stored value.


https://reviews.llvm.org/D22644





More information about the llvm-commits mailing list