[PATCH] D22537: [InstSimplify] recognize trunc + icmp sgt/slt variants of select simplifications (PR28466)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 13:52:00 PDT 2016


spatel updated this revision to Diff 64948.
spatel added a comment.

Patch updated:

1. https://reviews.llvm.org/D22602 forced us to deal with the vector bug, so I've added some vector test cases.
2. FIXME comments for refactoring were also added because https://reviews.llvm.org/D22602 exposed the code duplication sin.

I'd prefer to wait to add more patterns until I get some of the refactoring done. I don't see any quick fix here: 
To refactor these cmp instruction analyzers properly, we should make the alternate code in decomposeBitTestICmp() vector-friendly and that means breaking artificial limits (dyn_cast<ConstantInt> vs. m_APInt()) on a very large number of transforms.


https://reviews.llvm.org/D22537

Files:
  lib/Analysis/InstructionSimplify.cpp
  test/Transforms/InstSimplify/select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22537.64948.patch
Type: text/x-patch
Size: 7775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/eb09c129/attachment.bin>


More information about the llvm-commits mailing list