[PATCH] D22639: Add flag to PassManagerBuilder to disable GVN Hoist Pass.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 12:21:10 PDT 2016


mehdi_amini added a comment.

Let me rephrase, I had an inappropriate use of "ugly" here:

I'm not fond of these kind of targetted flags (on the contrary to "optimization level" for instance) on the PassManagerBuilder. The current state is not really satisfactory (too many, and they are not documented),  and it shows that we don't have a principled solution to control this.
It could slip toward a DisableXXX for each pass ultimately.

Since the motivation is "unblock temporarily the bots during the investigation of the bug" Can the faulty Halide test be disabled instead?


https://reviews.llvm.org/D22639





More information about the llvm-commits mailing list