[PATCH]: Solaris: 28645 - enhancements to the LLVM SPARC backend

[Daniel Berlin via llvm-commits]

Hi Stefan,

If you want to get this reviewed, I would create a phabricator review on
reviews.llvm.org, clearly describing what you are trying to do in the
patch, etc.

You reference a bug number, but the bug is just titled "enhancements to the
LLVM SPARC backend"

:)
That is not very helpful in figuring out the goal of the patch, etc.

Staring at the patch, it looks like it does a bunch of things. Some bug
fixes, some improvements.
 In general, you want to break up the different functional things it does
into individual patches so it is easy to review.

For example, i see:
 --- lib/Target/Sparc/SparcInstrInfo.td  2015-12-11 10:20:16.000000000 -0900
 +++ lib/Target/Sparc/SparcInstrInfo.td  2016-07-02 19:46:36.045655245 -0800
 @@ -348,7 +348,7 @@
  }

  // GETPCX for PIC
 -let Defs = [O7] in {
 +let Defs = [O7], hasSideEffects = 1 in {
    def GETPCX : Pseudo<(outs getPCX:$getpcseq), (ins), "$getpcseq", [] >;
  }

 ###


This looks like a bug fix, while other parts of the patch look like cpu
renamings, etc.

(I'm just guessing here).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/86092e05/attachment.html>