[PATCH] D22521: [MBP] do not reorder and move up loop latch block

[David Li via llvm-commits]

davidxl added a comment.

Please split the comment changes into  a different patch


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:88
@@ +87,3 @@
+//                    is broken only when the probability is high engough that this
+//                    looks beneficial to do so.
+
----------------
Just one line comment defining "Outlining" should be put here. The rest do not fit.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:578
@@ +577,3 @@
+  // If we choose Succ, then we break the topological ordering and Pred needs
+  // to be outlined which is shown here:
+  //
----------------
Remove redundunat "and Pred needs to be ....". Actually I don't see the need of modification of this paragraph.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:658
@@ -637,1 +657,3 @@
+                 << "Respecting topological ordering because "
+                 << "probability = " << SuccProb << "\n");
     return true;
----------------
add  "is less than probability threshold "


https://reviews.llvm.org/D22521