[PATCH] D22612: [compiler-rt] Disable some unittests on windows that rely on shell command

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:14:38 PDT 2016


rnk added inline comments.

================
Comment at: test/asan/TestCases/coverage-order-pcs.cc:22
@@ -21,2 +21,3 @@
 // Ordering works only in 64-bit mode for now.
 // REQUIRES: asan-64-bits
+// UNSUPPORTED: android, win32
----------------
Instead, this should be `REQUIRES: shell`. The test is failing because it uses environment variable expansion, which the lit internal shell doesn't support.

================
Comment at: test/asan/TestCases/coverage-tracing.cc:27
@@ -26,2 +26,3 @@
 //
 // REQUIRES: asan-64-bits
+// UNSUPPORTED: android, win32
----------------
Ditto, this is `REQUIRES: shell`

================
Comment at: test/asan/TestCases/no_asan_gen_globals.c:9
@@ -8,3 +8,3 @@
 // RUN: %clang_asan %s -o %t.exe
 // RUN: nm %t.exe | FileCheck %s
 
----------------
IMO if it uses `nm` we should just send it to test/asan/TestCases/Posix


https://reviews.llvm.org/D22612





More information about the llvm-commits mailing list