[PATCH] D22606: [compiler-rt] Fix broken unittest on win64

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:11:41 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

OK, let's do it the less fancy way. =/ lgtm


================
Comment at: test/asan/TestCases/debug_mapping.cc:24
@@ -17,3 +23,3 @@
   fprintf(stderr, "scale: %d\n", (int)scale);
-  fprintf(stderr, "offset: 0x%lx\n", offset);
+  fprintf(stderr, "offset: 0x" PTR "\n", (void*)offset);
 
----------------
This might produce -Wformat warnings, but I guess we don't care.

================
Comment at: test/asan/TestCases/debug_stacks.cc:44
@@ -37,3 +43,3 @@
   // CHECK: thread id = 0
-  fprintf(stderr, "0x%lx\n", trace[0]);
+  fprintf(stderr, "0x" PTR "\n", (void*)trace[0]);
   // CHECK: [[ALLOC_FRAME_0:0x[0-9a-f]+]]
----------------
No need to cast, this is already a void*, right?


https://reviews.llvm.org/D22606





More information about the llvm-commits mailing list