[PATCH] D22604: [ELF] - Initial support of tree-style linker script implemented.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 18:40:19 PDT 2016


ruiu added a comment.

LGTM with this change.


================
Comment at: ELF/LinkerScript.h:56
@@ +55,3 @@
+  BaseCommand(int K) : Kind(K) {}
+  int Kind;
+};
----------------
I think you need to define a virtual destructor because you are destructing derived classes instances through base class pointers.


https://reviews.llvm.org/D22604





More information about the llvm-commits mailing list