[PATCH] D22589: [ELF] - Introduce output section description class for holding section command

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 14:18:40 PDT 2016


grimar added a comment.

I see, nice.

But we use and have Name and for assignment, because can assign to location counter and to symbols outside of section declarations.
So I think it should be like next ?

  struct SectionsCommand {
    SectionsCommandKind Kind;
    AssignmentDescription Assignment;  // For AssignmentKind
    OutputSectionDescription Desc; // For DescriptionKind
  };
  
  struct AssignmentDescription {
    StringRef Name;
    std::vector<StringRef> Expr;
  };


https://reviews.llvm.org/D22589





More information about the llvm-commits mailing list