[lld] r276172 - [ELF][MIPS] Pick arch flag from the first input file.

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 13:39:21 PDT 2016


On Wed, Jul 20, 2016 at 11:29 PM, Rui Ueyama <ruiu at google.com> wrote:
> On Wed, Jul 20, 2016 at 4:15 PM, Simon Atanasyan via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: atanasyan
>> Date: Wed Jul 20 15:15:24 2016
>> New Revision: 276172
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=276172&view=rev
>> Log:
>> [ELF][MIPS] Pick arch flag from the first input file.

>> -static uint32_t getMipsEFlags(bool Is64Bits) {
>> -  // FIXME: In fact ELF flags depends on ELF flags of input object files
>> -  // and selected emulation. For now just use hard coded values.
>> +template <class ELFT>
>> +static uint32_t getMipsEFlags(bool Is64Bits,
>> +                              const ELFFileBase<ELFT> &FirstElf) {
>
>
> You can omit Is64Bits parameter because you can use ELFT::Is64Bits in this
> function instead. Moreover, you can omit FirstElf because it can be accessed
> through Config->FirstrObj.

Thanks. Fixed at r276176.

-- 
Simon Atanasyan


More information about the llvm-commits mailing list