[PATCH] D22462: [ARM][LLD] Initial support for ARM TLS

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 02:00:40 PDT 2016


peter.smith added a comment.

Thanks for the review, committed r276095


================
Comment at: ELF/Target.cpp:1522
@@ -1518,1 +1521,3 @@
+  case R_ARM_TLS_IE32:
+    // GOT(S) + - P
     return R_GOT_PC;
----------------
ruiu wrote:
> `+ -`?
The comment GOT(S) + - Got_ORG is wrong. In fact the above line is also wrong as it is missing A. It should be GOT(S) + A - P.



Repository:
  rL LLVM

https://reviews.llvm.org/D22462





More information about the llvm-commits mailing list