[PATCH] D22074: GlobalISel: legalization policy class

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: include/llvm/CodeGen/GlobalISel/MachineLegalizer.h:86
@@ +85,3 @@
+  /// Compute any ancillary tables needed to quickly decide how an operation
+  /// should be handled. This must be called after all "set*Action"methods but
+  /// before any query is made or incorrect results may be returned.
----------------
:D

================
Comment at: include/llvm/CodeGen/GlobalISel/MachineLegalizer.h:110
@@ +109,3 @@
+  std::pair<LegalizeAction, LLT> getAction(unsigned Opcode, LLT) const;
+  std::pair<LegalizeAction, LLT> getAction(MachineInstr &MI) const;
+
----------------
Could you mention that in a comment?


Repository:
  rL LLVM

https://reviews.llvm.org/D22074