[llvm] r276057 - Get rid of call to StringRef::substr that's never used.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 16:19:22 PDT 2016


Author: jlebar
Date: Tue Jul 19 18:19:22 2016
New Revision: 276057

URL: http://llvm.org/viewvc/llvm-project?rev=276057&view=rev
Log:
Get rid of call to StringRef::substr that's never used.

Summary: substr doesn't modify the string, so this line has no effect.

Reviewers: majnemer

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D22540

Modified:
    llvm/trunk/lib/Support/CommandLine.cpp

Modified: llvm/trunk/lib/Support/CommandLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CommandLine.cpp?rev=276057&r1=276056&r2=276057&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CommandLine.cpp (original)
+++ llvm/trunk/lib/Support/CommandLine.cpp Tue Jul 19 18:19:22 2016
@@ -505,7 +505,6 @@ static bool CommaSeparateAndAddOccurrenc
         return true;
       // Erase the portion before the comma, AND the comma.
       Val = Val.substr(Pos + 1);
-      Value.substr(Pos + 1); // Increment the original value pointer as well.
       // Check for another comma.
       Pos = Val.find(',');
     }




More information about the llvm-commits mailing list