[PATCH] D22545: Make GVN Hoisting obey optnone/bisect

[Daniel Berlin via llvm-commits]

LGTM

On Tue, Jul 19, 2016 at 3:35 PM, Paul Robinson <paul.robinson at sony.com>
wrote:

> probinson created this revision.
> probinson added reviewers: chandlerc, dberlin.
> probinson added a subscriber: llvm-commits.
>
> AFAICT the new pass manager does not support this feature yet?
>
>
> https://reviews.llvm.org/D22545
>
> Files:
>   lib/Transforms/Scalar/GVNHoist.cpp
>   test/Feature/optnone-opt.ll
>
> Index: test/Feature/optnone-opt.ll
> ===================================================================
> --- test/Feature/optnone-opt.ll
> +++ test/Feature/optnone-opt.ll
> @@ -41,6 +41,7 @@
>  ; OPT-O1-DAG: Skipping pass 'Combine redundant instructions'
>  ; OPT-O1-DAG: Skipping pass 'Dead Store Elimination'
>  ; OPT-O1-DAG: Skipping pass 'Early CSE'
> +; OPT-O1-DAG: Skipping pass 'Early GVN Hoisting of Expressions'
>  ; OPT-O1-DAG: Skipping pass 'Jump Threading'
>  ; OPT-O1-DAG: Skipping pass 'MemCpy Optimization'
>  ; OPT-O1-DAG: Skipping pass 'Reassociate expressions'
> Index: lib/Transforms/Scalar/GVNHoist.cpp
> ===================================================================
> --- lib/Transforms/Scalar/GVNHoist.cpp
> +++ lib/Transforms/Scalar/GVNHoist.cpp
> @@ -766,6 +766,8 @@
>    }
>
>    bool runOnFunction(Function &F) override {
> +    if (skipFunction(F))
> +      return false;
>      auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
>      auto &AA = getAnalysis<AAResultsWrapperPass>().getAAResults();
>      auto &MD = getAnalysis<MemoryDependenceWrapperPass>().getMemDep();
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160719/7d3ba1b3/attachment.html>