[PATCH] D21421: [NVPTX] Improve lowering of byval args of device functions.

[Justin Lebar via llvm-commits]

jlebar added a comment.

lgtm.  I don't have a problem if we rename the pass and in a separate patch, but I do think we should do that.


================
Comment at: lib/Target/NVPTX/NVPTXLowerKernelArgs.cpp:12
@@ -14,1 +11,3 @@
+// 1. Copy byval struct args of kernel and device functions to local
+//    memory. This is a preparation for handling cases like
 //
----------------
OK, but carrying this one list when we use it for two different things ("things we do to all functions" vs "things we do to kernel functions") is confusing.

Can we make it so this first one isn't part of the list?


https://reviews.llvm.org/D21421