[PATCH] D22368: Replace hot-callsite based heuristic to use its own threshold parameter instead of share inline-hint parameter

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 11:05:44 PDT 2016


davidxl added a comment.

should we have a fixed cutoff threshold, or make it adaptive to the hotness ? Or more generally, make it part of the global speedup analysis (the larger the global speedup, the larger the speedup) -- which we will soon have?

Another thing: PGO and autoFDO should reduce overall text size compared with O2 build, so we should also do the opposite -- if the caller has zero count (non samples with autoFDO), the threshold should be reduced.


https://reviews.llvm.org/D22368





More information about the llvm-commits mailing list