[PATCH] D21421: [NVPTX] Improve lowering of byval args of device functions.

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 10:30:57 PDT 2016


tra planned changes to this revision.
tra added a comment.

I have no idea why phabricator marks this revision as accepted when I update the patch. Marking it as "Plan changes", again.


================
Comment at: lib/Target/NVPTX/NVPTXLowerKernelArgs.cpp:10
@@ -9,3 +9,3 @@
 //
 // Pointer arguments to kernel functions need to be lowered specially.
 //
----------------
jlebar wrote:
> This comment needs to be updated.
> 
> Actually, doing any of this work in a pass called "LowerKernelArgs" seems wrong.  Should we rename the pass?
Comment updated. As for renaming the file/pass, I'd rather do it separately.


https://reviews.llvm.org/D21421





More information about the llvm-commits mailing list