[PATCH] D22356: [ThinLTO] Perform conservative weak/linkonce resolution in distributed backend case

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 17:01:37 PDT 2016


tejohnson added a comment.

In https://reviews.llvm.org/D22356#487588, @mehdi_amini wrote:

> Right now it is not clear to me why it would be legit (understand: if it should be supported) to perform the second link using static archive.
>  The first link already selected object from the archives, so we should be able to provide a list of objects to the second/final link.


That's a good question and an idea I thought about briefly but discarded for a couple reasons. I was concerned about requiring communication between the ThinLink and final link to build the link line (it would be more difficult to support in a build system, and also seems conceptually more complicated). Also I'm not 100% convinced that removing the --start-lib/--end-lib, even if we only include those object files the linker decided to select symbols from, would result in the same linking behavior. But maybe I just need to think through that some more...


https://reviews.llvm.org/D22356





More information about the llvm-commits mailing list