[PATCH] D22181: Add runtime support for __cpu_model (__builtin_cpu_supports)

[Eric Christopher via llvm-commits]

Ah, that's probably the difference.

Thanks :)

-eric

On Mon, Jul 18, 2016 at 2:47 PM Vitaly Buka <vitalybuka at google.com> wrote:

> On first look I see asm only in *.cc files, all *.c files have __asm__
>
>
> On Mon, Jul 18, 2016 at 2:04 PM Eric Christopher <echristo at gmail.com>
> wrote:
>
>> Ok, thanks. Please follow up when you have something.
>>
>> -eric
>>
>> On Mon, Jul 18, 2016 at 2:00 PM Vitaly Buka <vitalybuka at google.com>
>> wrote:
>>
>>> No, not yet.
>>>
>>> On Mon, Jul 18, 2016 at 1:23 PM Eric Christopher <echristo at gmail.com>
>>> wrote:
>>>
>>>> Vitaly: Have you figured out what was going on here? The lack of
>>>> consistency among all of the files is concerning and I'm not seeing the
>>>> failure at build time myself which makes it difficult to ensure before
>>>> check-in.
>>>>
>>>> Thanks.
>>>>
>>>> -eric
>>>>
>>>>
>>>> On Fri, Jul 15, 2016 at 4:14 PM Eric Christopher <echristo at gmail.com>
>>>> wrote:
>>>>
>>>>> This is particularly weird as compiler-rt is inconsistent with whether
>>>>> or not we use __asm__, __asm, or asm in a bunch of files that we'll
>>>>> definitely build for asan (sanitizer_syscall_linux_x86_64.inc for example).
>>>>>
>>>>> We can change it to __asm__ but I'd like to know why this isn't
>>>>> showing up otherwise.
>>>>>
>>>>>
>>>>> On Fri, Jul 15, 2016 at 4:03 PM Vitaly Buka <vitalybuka at google.com>
>>>>> wrote:
>>>>>
>>>>>> -DLLVM_ENABLE_WERROR=ON is set on here bot. I don't see this on general bots.
>>>>>>
>>>>>>
>>>>>> On Fri, Jul 15, 2016 at 3:54 PM Eric Christopher <echristo at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Huh, does the sanitizer bot have different warnings options? Perhaps
>>>>>>> we could turn it on in general?
>>>>>>>
>>>>>>> On Fri, Jul 15, 2016 at 3:37 PM Vitaly Buka <vitalybuka at google.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> vitalybuka added a subscriber: vitalybuka.
>>>>>>>> vitalybuka added a comment.
>>>>>>>>
>>>>>>>> The patch introduced this:
>>>>>>>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24764/steps/build%20with%20ninja/logs/stdio
>>>>>>>>
>>>>>>>> FAILED:
>>>>>>>> /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/clang_build/bin/clang
>>>>>>>> -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
>>>>>>>> -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/builtins
>>>>>>>> -I/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins
>>>>>>>> -Iinclude
>>>>>>>> -I/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/include
>>>>>>>> -gmlt -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings
>>>>>>>> -Wmissing-field-initializers -pedantic -Wno-long-long
>>>>>>>> -Wcovered-switch-default -Wdelete-non-virtual-dtor -Werror
>>>>>>>> -Werror=date-time -fcolor-diagnostics -ffunction-sections -fdata-sections
>>>>>>>> -Wall -Werror -Wno-unused-parameter -O3    -UNDEBUG  -m32  -std=gnu99 -MMD
>>>>>>>> -MT
>>>>>>>> projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o
>>>>>>>> -MF
>>>>>>>> projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o.d
>>>>>>>> -o
>>>>>>>> projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o
>>>>>>>>  -c
>>>>>>>> /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c
>>>>>>>> /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c:174:3:
>>>>>>>> error: extension used [-Werror,-Wlanguage-extension-token]
>>>>>>>>
>>>>>>>>   asm("movl\t%%ebx, %%esi\n\t"
>>>>>>>>   ^
>>>>>>>>
>>>>>>>> /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c:224:3:
>>>>>>>> error: extension used [-Werror,-Wlanguage-extension-token]
>>>>>>>>
>>>>>>>>   asm("movl\t%%ebx, %%esi\n\t"
>>>>>>>>
>>>>>>>>
>>>>>>>> Repository:
>>>>>>>>   rL LLVM
>>>>>>>>
>>>>>>>> https://reviews.llvm.org/D22181
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160718/aefe225d/attachment.html>