[PATCH] D22449: [InstCombine] NFC: Minor code cleanup

[Tobias Grosser via llvm-commits]

grosser added a comment.

This patch looks great. Just a couple of minor comments left:

- I would suggest a slightly more descriptive title: [InstCombine] Minor cleanup of cast simplification code [NFC]

- Two typos (see below)

- Use present tense in commit message (you are describing the commit, not an event in the past)


================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:394
@@ +393,3 @@
+  ///
+  /// \param ICI The icmp of the (zext icmp) pair we are intersted in.
+  /// \parem CI The zext of the (zext icmp) pair we are intersted in.
----------------
interested

================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:395
@@ +394,3 @@
+  /// \param ICI The icmp of the (zext icmp) pair we are intersted in.
+  /// \parem CI The zext of the (zext icmp) pair we are intersted in.
+  /// \param DoTransform Pass false to just test whether the given (zext icmp)
----------------
interested

================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:423
@@ +422,3 @@
+  /// Instruction::CastOps value for a cast that can replace the pair, casting
+  /// CI1->getSrcTy() to CI2->getDstTy().
+  Instruction::CastOps isEliminableCastPair(const CastInst *CI1,
----------------
Add reference @see CastInst::isEliminableCastPair


https://reviews.llvm.org/D22449